lint: Enforce consistent return

While all javascript functions have a return value - either an explicit
one from a return statement, or an implicit "undefined" - mixing both in
the same function is almost certainly an oversight, and more often than
not a bug.

Enable the corresponding eslint rule to catch those errors.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/635

diff --git a/lint/eslintrc-shell.json b/lint/eslintrc-shell.json
index 9c4c96bbac8a70dba704d6b2d311f63c5c8c94f4..d8a940bbb7ced45f91506e75923ddc0ba76dc332 100644 (file)
--- a/lint/eslintrc-shell.json
+++ b/lint/eslintrc-shell.json
@@ -7,6 +7,7 @@
                 "allow": ["^vfunc_", "^on_"]
             }
         ],
+        "consistent-return": "error",
         "key-spacing": [
             "error",
             {